Fix crash at thread exit#591
Conversation
|
CI Test ResultsRun: #27370600787 | Commit:
Status Overview
Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled Summary: Total: 32 | Passed: 32 | Failed: 0 Updated: 2026-06-11 19:19:28 UTC |
BitsAI couldn’t fix CIBitsAI couldn’t produce a safe fix for this CI failure. Open the Datadog session to inspect the attempt or continue from there. Progress 🟢 Investigated · 🔴 Fix failed · ⚪ Validate · ⚪ Ready Commit: |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bcbbfcb817
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0e50af7e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fe3f44dc3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ine() returns without pthread_exit or cancellation
2 participants
What does this PR do?:
Fixed crashes during thread exit cleanup.
Motivation:
Improve stability.
Additional Notes:
On glibc, pthread_exit and pthread_cancel trigger _Unwind_ForcedUnwind from the dynamic libgcc_s.so.1. When the forced unwind walks a frame belonging to code built with -static-libgcc (both libjavaProfiler.so and the gtest binaries), it calls the static __gxx_personality_v0. The two libgcc versions have incompatible _Unwind_Context layouts. If the personality function finds a cleanup or handler action and calls _Unwind_SetGR, the cold/error path aborts.
Two patterns create LSDA actions that trigger _Unwind_SetGR:
How to test the change?:
Three failed tests now passed.
For Datadog employees:
credentials of any kind, I've requested a review from
@DataDog/security-design-and-guidance.Unsure? Have a question? Request a review!